Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19201 )
Change subject: IMPALA-11702: add some resource metrics for kudu scanner to profile ...................................................................... Patch Set 2: Code-Review+1 (6 comments) Thanks to work on this. Just a few nits. http://gerrit.cloudera.org:8080/#/c/19201/2/be/src/exec/kudu/kudu-scan-node-base.cc File be/src/exec/kudu/kudu-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/19201/2/be/src/exec/kudu/kudu-scan-node-base.cc@49 PS2, Line 49: k nit: Kudu http://gerrit.cloudera.org:8080/#/c/19201/2/be/src/exec/kudu/kudu-scan-node-base.cc@52 PS2, Line 52: for kudu nit: handled by Kudu scanners, or handed to Kudu scanners http://gerrit.cloudera.org:8080/#/c/19201/2/be/src/exec/kudu/kudu-scan-node-base.cc@54 PS2, Line 54: k nit: Kudu http://gerrit.cloudera.org:8080/#/c/19201/2/be/src/exec/kudu/kudu-scan-node-base.cc@56 PS2, Line 56: k nit: Kudu http://gerrit.cloudera.org:8080/#/c/19201/2/be/src/exec/kudu/kudu-scan-node-base.cc@58 PS2, Line 58: k nit: Kudu http://gerrit.cloudera.org:8080/#/c/19201/2/be/src/exec/kudu/kudu-scan-node-base.cc@61 PS2, Line 61: k nit: Kudu -- To view, visit http://gerrit.cloudera.org:8080/19201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0e84e7756ce92af48fa55672157caafcd396547 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Nov 2022 18:10:14 +0000 Gerrit-HasComments: Yes
