Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17771 )
Change subject: WiP: IMPALA-10798 : Prototype for JSON reader ...................................................................... Patch Set 22: (33 comments) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-json-scanner.cc File be/src/exec/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-json-scanner.cc@171 PS22, Line 171: // VLOG_QUERY << "decimal128" << arrow::decimal128(ct.precision, ct.scale)->ToString(); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@70 PS22, Line 70: "for all reads, regardless of whether the read is local or remote. By default, the " line too long (126 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@71 PS22, Line 71: "IO data cache is only used if the data is expected to be remote. Used by tests."); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@79 PS22, Line 79: " across all Disk I/O threads in HDFS read operations."); line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@81 PS22, Line 81: " spent across all Disk I/O threads in HDFS open operations."); line too long (122 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@84 PS22, Line 84: " while it is executing I/O operations on behalf of a scan."); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@91 PS22, Line 91: "disks accessed by HDFS scan. Each local disk is counted as a disk and each type of" line too long (150 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@92 PS22, Line 92: " remote filesystem (e.g. HDFS remote reads, S3) is counted as a distinct disk."); line too long (148 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@94 PS22, Line 94: " average number of HDFS read threads executing read operations on behalf of this " line too long (161 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@95 PS22, Line 95: "scan. Higher values (i.e. close to the aggregate number of I/O threads across " line too long (158 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@96 PS22, Line 96: "all disks accessed) show that this scan is using a larger proportion of the I/O " line too long (160 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@97 PS22, Line 97: "capacity of the system. Lower values show that either this scan is not I/O bound" line too long (160 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@98 PS22, Line 98: " or that it is getting a small share of the I/O capacity of the system."); line too long (153 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@106 PS22, Line 106: "Use this to determine if the scan got all of the reservation it wanted. Does not " line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@107 PS22, Line 107: "include subsequent reservation increases done by scanner implementation " line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@127 PS22, Line 127: "threads spent waiting for I/O. This value can be compared to the value of " line too long (128 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@128 PS22, Line 128: "ScannerThreadsTotalWallClockTime of MT_DOP = 0 scan nodes or otherwise compared " line too long (134 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@129 PS22, Line 129: "to the total time reported for MT_DOP > 0 scan nodes. High values show that " line too long (130 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@130 PS22, Line 130: "scanner threads are spending significant time waiting for I/O instead of " line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@131 PS22, Line 131: "processing data. Note that this includes the time when the thread is runnable " line too long (132 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@135 PS22, Line 135: "Each sample in the counter is the size of a single column that is scanned by the " line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@139 PS22, Line 139: "Each sample in the counter is the size of a single column that is scanned by the " line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@747 PS22, Line 747: metadata->partition_id, FilterStats::FILES_KEY, filter_ctxs, file, state)) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@1231 PS22, Line 1231: "Read $0 of data across network that was expected to be local. Block locality " line too long (144 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@1232 PS22, Line 1232: "metadata for table '$1.$2' may be stale. This only affects query performance " line too long (144 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@1233 PS22, Line 1233: "and not result correctness. One of the common causes for this warning is HDFS " line too long (145 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@1234 PS22, Line 1234: "rebalancer moving some of the file's blocks. If the issue persists, consider " line too long (144 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@1235 PS22, Line 1235: "running \"INVALIDATE METADATA `$1`.`$2`\".", line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@1236 PS22, Line 1236: PrettyPrinter::Print(unexpected_remote_bytes_->value(), TUnit::BYTES), line too long (135 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/be/src/exec/hdfs-scan-node-base.cc@1237 PS22, Line 1237: hdfs_table_->database(), hdfs_table_->name()))); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/17771/22/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/17771/22/bin/bootstrap_toolchain.py@489 PS22, Line 489: " flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17771/22/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/17771/22/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@475 PS22, Line 475: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/22/tests/query_test/test_tpch_queries.py File tests/query_test/test_tpch_queries.py: http://gerrit.cloudera.org:8080/#/c/17771/22/tests/query_test/test_tpch_queries.py@39 PS22, Line 39: s flake8: E501 line too long (96 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/17771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79364a421d862d0d837f9be694911e388d4d629 Gerrit-Change-Number: 17771 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward <shikha.asran...@gmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <shikha.asran...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 10 Nov 2022 06:18:08 +0000 Gerrit-HasComments: Yes
