Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19234 )

Change subject: IMPALA-11721: Impala query keep being retried over frequently 
updated iceberg table
......................................................................


Patch Set 2:

(2 comments)

Thanks for your comments!

Qifan: I added a paragraph to the commit message that answers your question.

http://gerrit.cloudera.org:8080/#/c/19234/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19234/1//COMMIT_MSG@31
PS1, Line 31: catalog
> nit: catalog version?
Done


http://gerrit.cloudera.org:8080/#/c/19234/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/19234/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@122
PS1, Line 122: warmupMetaP
> nit. May name it as warmupMetaProviderCache() to make it clear.
Done



--
To view, visit http://gerrit.cloudera.org:8080/19234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac28224b2b6d67725eeb17f3e9d813ba622edb43
Gerrit-Change-Number: 19234
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tma...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Nov 2022 11:01:46 +0000
Gerrit-HasComments: Yes

Reply via email to