Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 )
Change subject: IMPALA-11730: Add support for spilling to Ozone ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19251/5/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/19251/5/be/src/runtime/tmp-file-mgr.cc@1358 PS5, Line 1358: HDFS or S3 nit. may need to add Ozone in the comment. http://gerrit.cloudera.org:8080/#/c/19251/5/tests/custom_cluster/test_scratch_disk.py File tests/custom_cluster/test_scratch_disk.py: http://gerrit.cloudera.org:8080/#/c/19251/5/tests/custom_cluster/test_scratch_disk.py@412 PS5, Line 412: def test_scratch_dirs_remote_spill_concurrent(self, vector): > This failed in my S3 test run with If that is the case, probably means all the files fail to upload, could be a s3 setting issue. May find the errors in the log. -- To view, visit http://gerrit.cloudera.org:8080/19251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5837c30357363f727ca832fb94169f2474fb4f6f Gerrit-Change-Number: 19251 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 22:48:29 +0000 Gerrit-HasComments: Yes
