Qifan Chen has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19220 )
Change subject: IMPALA-11707: Fix global runtime IN-list filter of numeric types are AlwaysFalse ...................................................................... IMPALA-11707: Fix global runtime IN-list filter of numeric types are AlwaysFalse Global runtime filters are published to the coordinator and then distributed to all executors that need it. The filter is serialized and deserialized using protobuf. While deserializing a global runtime filter of numeric type from protobuf, the InsertBatch() method forgot to update the total_entries_ counter. The filter is then considered as an empty list, which will reject any files/rows. This patch adds the missing update of total_entries_. Some DCHECKs are added to make sure total_entries_ is consistent with the actual size of the value set. This patch also fixes a type error (long_val -> int_val) in ToProtobuf() of Date type IN-list filter. Tests: - Added BE tests to verify the filter cloned from protobuf has the same behavior as the original one. - Added e2e regression tests - Run TestInListFilters 200 times. Change-Id: Ie90b2bce5e5ec6f6906ce9d2090b0ab19d48cc78 Reviewed-on: http://gerrit.cloudera.org:8080/19220 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Qifan Chen <qfc...@hotmail.com> --- M be/src/runtime/runtime-filter-bank.h M be/src/util/in-list-filter-ir.cc M be/src/util/in-list-filter-test.cc M be/src/util/in-list-filter.cc M be/src/util/in-list-filter.h M testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test 6 files changed, 250 insertions(+), 78 deletions(-) Approvals: Impala Public Jenkins: Verified Qifan Chen: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie90b2bce5e5ec6f6906ce9d2090b0ab19d48cc78 Gerrit-Change-Number: 19220 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
