Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18219 )
Change subject: IMPALA-11064 Optimizing Temporary File Structure for Batch Reading ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/18219/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18219/10//COMMIT_MSG@131 PS10, Line 131: TODO add more testcases. Are you still planning to add more test cases? http://gerrit.cloudera.org:8080/#/c/18219/10/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/18219/10/be/src/exec/partitioned-hash-join-builder.cc@181 PS10, Line 181: base_spill_id_(PhjBuilderConfig::GenerateBaseSpillId( nit: Indentation's wrong here. http://gerrit.cloudera.org:8080/#/c/18219/10/be/src/exec/partitioned-hash-join-builder.cc@182 PS10, Line 182: state->query_options().base_spill_id_level, (uint64_t)this)){ nit: Should have a space after closing parens. -- To view, visit http://gerrit.cloudera.org:8080/18219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If913785cac9e2dafa20013b6600c87fcaf3e2018 Gerrit-Change-Number: 18219 Gerrit-PatchSet: 10 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 18:53:00 +0000 Gerrit-HasComments: Yes
