Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 )
Change subject: IMPALA-11728: Set fallback database for functions ...................................................................... Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG@7 PS7, Line 7: : Set > nit: missing : Done http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG@10 PS7, Line 10: When using the function in another database, it will throw an AnalysisException > Could add that the function is used without specifying the database. When t I added in case 1. http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG@11 PS7, Line 11: own in the current da > Do you mean "the function is unknown in the current database"? Yes, I changed the description. http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG@13 PS7, Line 13: Add query option FALLBACK_DB_FOR_FUNCTIONS. When setting fallback database > Can you add the exact name of the query option here or in the title? Done http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG@15 PS7, Line 15: > Could add the exact precedence of the functions: Done http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG@16 PS7, Line 16: The exact precedence of the functions: > Some example in the commit message could make this feature very clear, e.g. I added four test case descriptions. http://gerrit.cloudera.org:8080/#/c/19252/7/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/19252/7/tests/query_test/test_udfs.py@649 PS7, Line 649: create_function_stmt = "create function `{0}`.fn() returns int "\ > This is not needed, as unique_database always starts empty. Done http://gerrit.cloudera.org:8080/#/c/19252/7/tests/query_test/test_udfs.py@677 PS7, Line 677: > No need to cleanup, a DROP DATABASE CASCADE will be ran after the test. Done -- To view, visit http://gerrit.cloudera.org:8080/19252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b7e126718fea1c50723cacbaed898b20bb55e5 Gerrit-Change-Number: 19252 Gerrit-PatchSet: 8 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Wed, 23 Nov 2022 05:50:56 +0000 Gerrit-HasComments: Yes
