lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19270 )
Change subject: IMPALA-11739: Iceberg partitioning column cannot be filtered not equal NULL or equal NULL ...................................................................... Patch Set 3: (4 comments) LGTM and some minor comments. http://gerrit.cloudera.org:8080/#/c/19270/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19270/3//COMMIT_MSG@7 PS3, Line 7: Iceberg partitioning column cannot be filtered not equal NULL or equal NULL nit: That might be a clearer description 'Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables' http://gerrit.cloudera.org:8080/#/c/19270/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19270/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@659 PS1, Line 659: > I change it just like Ok, I can accept that. http://gerrit.cloudera.org:8080/#/c/19270/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19270/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@559 PS3, Line 559: IN or NOT_IN predicate nit: BinaryPredicate http://gerrit.cloudera.org:8080/#/c/19270/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test: http://gerrit.cloudera.org:8080/#/c/19270/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test@317 PS3, Line 317: action = NULL nit: Perhaps we should add '! =' test case -- To view, visit http://gerrit.cloudera.org:8080/19270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6c50978ebac2590622027a239db03f56b082de3 Gerrit-Change-Number: 19270 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Nov 2022 09:49:56 +0000 Gerrit-HasComments: Yes
