Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19084 )
Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files ...................................................................... Patch Set 5: Code-Review+1 (6 comments) LGTM, marked some nits. http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@72 PS5, Line 72: import org.apache.impala.fb.FbIcebergDataFileFormat; nit: unused import http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@83 PS5, Line 83: import org.apache.impala.thrift.TIcebergFileFormat; nit: unused import http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@100 PS5, Line 100: import org.apache.impala.util.IcebergUtil; nit: unused import http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1765 PS5, Line 1765: org.apache.hadoop.hive.metastore.api.Table msTbl) throws Exception { nit: indentation should be 4 spaces http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@82 PS5, Line 82: if (hasAvro) { nit: this could be merged with the previous condition http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@85 PS5, Line 85: + "file format are not supported."); nit: indentation should be 4 spaces -- To view, visit http://gerrit.cloudera.org:8080/19084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I827e5707e54bebabc614e127daa48255f86f4c4f Gerrit-Change-Number: 19084 Gerrit-PatchSet: 5 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Mon, 28 Nov 2022 08:44:42 +0000 Gerrit-HasComments: Yes
