Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19279 )
Change subject: IMPALA-11744: Table mask view should reserve the original column order in Hive ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Thanks for quickly preparing the fix for this subtle bug Quanlong! I only have 3 very minor comments. http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@941 PS2, Line 941: List<Column> columns = resolvedTableRef.getSelectedColumnsInHiveOrder(); Could we add a code comment here to point out that the selected columns should be in the same relative order as they are in the corresponding Hive table so that the order of the SelectListItem's in the InlineViewRef would be correct? http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1611 PS2, Line 1611: Register scalar columns. Used in resolving column mask. Could we also add a code comment here to point out that the order in which columns are registered is not necessarily the same as the relative order of those columns in the corresponding Hive table? http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java@793 PS2, Line 793: reserve nit: preserve -- To view, visit http://gerrit.cloudera.org:8080/19279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic83d78312b19fa2c5ab88ac4f359bfabaeaabce6 Gerrit-Change-Number: 19279 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 09:29:21 +0000 Gerrit-HasComments: Yes
