Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 )
Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState ...................................................................... Patch Set 1: (4 comments) Left some minor comments, otherwise looks good to me! http://gerrit.cloudera.org:8080/#/c/19289/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19289/1//COMMIT_MSG@47 PS1, Line 47: with without? http://gerrit.cloudera.org:8080/#/c/19289/1/be/src/exec/avro/hdfs-avro-scanner.h File be/src/exec/avro/hdfs-avro-scanner.h: http://gerrit.cloudera.org:8080/#/c/19289/1/be/src/exec/avro/hdfs-avro-scanner.h@124 PS1, Line 124: The ownership of memory is transferred to the scan-node pool, Please update this comment. http://gerrit.cloudera.org:8080/#/c/19289/1/be/src/exec/avro/hdfs-avro-scanner.cc File be/src/exec/avro/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/19289/1/be/src/exec/avro/hdfs-avro-scanner.cc@292 PS1, Line 292: no partition columns nit: and no default values? http://gerrit.cloudera.org:8080/#/c/19289/1/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/19289/1/be/src/exec/hdfs-scan-node-base.cc@1305 PS1, Line 1305: metadata_lock_ Currently 'metadata_lock_' is used to protect 'per_file_metadata_'. And 'template_pool_' has unprotected accesses in hdfs-scan-node-base.cc, e.g. in HdfsScanPlanNode::Close(). Are we sure it won't cause any concurrency issue? -- To view, visit http://gerrit.cloudera.org:8080/19289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafa43fce7c2ffdc867004d11e5873327c3d8cb42 Gerrit-Change-Number: 19289 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 15:13:32 +0000 Gerrit-HasComments: Yes
