Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 )
Change subject: IMPALA-11478: Cleanup JniCatalog ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19198/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19198/3//COMMIT_MSG@13 PS3, Line 13: Frontend test added as JniCatalogOpTest. > Thanks for doing the experiment! These looks good to me. Just one question: If the duration is 0 then PrintUtils.printTimeMs() will return an empty string, that's why these log entries have no time spent value, and it worked the same way before this patch. http://gerrit.cloudera.org:8080/#/c/19198/4/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/19198/4/fe/src/main/java/org/apache/impala/common/JniUtil.java@176 PS4, Line 176: getDurationFromStart(); > nit: getDurationFromStart() Done -- To view, visit http://gerrit.cloudera.org:8080/19198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1932172e2d13a7aab2336661c18befb4407ec9ab Gerrit-Change-Number: 19198 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 08:53:52 +0000 Gerrit-HasComments: Yes