Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 )
Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > nit: Didn't go through the usages, but is there any reason we can't use > expectedWarning == null as the condition for zero warning? Do we actually use > it loosely, when we don't provide the expected warnings? Yeah, that's my first thought. Then I found many places we just use expectedWarning == null to ignore the warnings. E.g. This test actually has warning "Path 'hdfs://localhost:20500/a' cannot be reached: Path does not exist." https://github.com/apache/impala/blob/b17446818c548487fa5d71c678088ed35eed5bc8/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java#L718 This test actually has warning "Unpartitioned Kudu tables are inefficient for large data sizes." https://github.com/apache/impala/blob/b17446818c548487fa5d71c678088ed35eed5bc8/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java#L2314-L2315 This test actually has warning "Ignoring TABLESAMPLE because the effective sampling rate is 100%. The minimum sample size is COMPUTE_STATS_MIN_SAMPLE_SIZE=1.00GB and the table size 478.45KB" https://github.com/apache/impala/blob/b17446818c548487fa5d71c678088ed35eed5bc8/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java#L1737 It's out of the scope of this patch to add all the missing warnings. So I choose the current solution, i.e. explicitly mention "without warnings". -- To view, visit http://gerrit.cloudera.org:8080/19186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0871b94dcd2290723699c21227a576e8a6a09b5a Gerrit-Change-Number: 19186 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:24:25 +0000 Gerrit-HasComments: No
