Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19304 )

Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive 
java types
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/19304/1/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java
File 
fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java:

http://gerrit.cloudera.org:8080/#/c/19304/1/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@32
PS1, Line 32: import 
org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory;
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/19304/1/fe/src/main/java/org/apache/impala/hive/executor/JavaUdfDataType.java
File fe/src/main/java/org/apache/impala/hive/executor/JavaUdfDataType.java:

http://gerrit.cloudera.org:8080/#/c/19304/1/fe/src/main/java/org/apache/impala/hive/executor/JavaUdfDataType.java@25
PS1, Line 25: import 
org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory;
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/19304/1/fe/src/main/java/org/apache/impala/hive/executor/JavaUdfDataType.java@26
PS1, Line 26: import 
org.apache.hadoop.hive.serde2.objectinspector.primitive.AbstractPrimitiveWritableObjectInspector;
line too long (104 > 90)


http://gerrit.cloudera.org:8080/#/c/19304/1/fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdfWithJavaReturnTypes.java
File 
fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdfWithJavaReturnTypes.java:

http://gerrit.cloudera.org:8080/#/c/19304/1/fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdfWithJavaReturnTypes.java@25
PS1, Line 25: import 
org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory;
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/19304/1/fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdfWithJavaReturnTypes.java@26
PS1, Line 26: import 
org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory;
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/19304/1/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdfWithJavaReturnTypes.java
File 
java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdfWithJavaReturnTypes.java:

http://gerrit.cloudera.org:8080/#/c/19304/1/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdfWithJavaReturnTypes.java@25
PS1, Line 25: import 
org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory;
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/19304/1/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdfWithJavaReturnTypes.java@26
PS1, Line 26: import 
org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory;
line too long (95 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/19304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30679045d6693ebd35718b6f1a22aaa4963c1e63
Gerrit-Change-Number: 19304
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 18:06:21 +0000
Gerrit-HasComments: Yes

Reply via email to