Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19313 )
Change subject: IMPALA-10871: (Addendum) use variable substitution for Hive 3 profile ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19313/1/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/19313/1/fe/pom.xml@1065 PS1, Line 1065: <name>${hive.dist.type}</name> > I think they are always identical. Is there a case that they are different? The previous code didn't actually perform substitution, it used the raw string "env.IMPALA_HIVE_DIST_TYPE". I decided to use the variable since it was available rather than just wrap it in "${...}". -- To view, visit http://gerrit.cloudera.org:8080/19313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3d6a3ed55f1bd2e4d423b7d41ef595c6a054621 Gerrit-Change-Number: 19313 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 17:22:01 +0000 Gerrit-HasComments: Yes
