Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 )
Change subject: IMPALA-11736: Copy data between ofs buckets ...................................................................... Patch Set 6: Code-Review+2 (1 comment) This looks good to me http://gerrit.cloudera.org:8080/#/c/19262/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19262/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@310 PS5, Line 310: boolean doRename = destIsDfs && sameBucket && sameE > sameEncryptionZone makes that redundant, but I guess it wouldn't hurt to ke Yeah, I think the logic in arePathsInSameHdfsEncryptionZone() is pretty minimal if encryption is off. -- To view, visit http://gerrit.cloudera.org:8080/19262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic61f01672fa605fec0377885b13a1621573e424e Gerrit-Change-Number: 19262 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Dec 2022 00:50:45 +0000 Gerrit-HasComments: Yes
