Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 )
Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Thanks for implementing this, LGMT! http://gerrit.cloudera.org:8080/#/c/19145/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19145/4/fe/src/main/java/org/apache/impala/service/Frontend.java@974 PS4, Line 974: > This is just to signal that the number of loaded files can be plural. I think this is a copy paste error too, FileSystemUtil.getTotalNumVisibleFiles(destPath) is unused (but String.format() does not tell you that unfortunately), that's the source of the confusion. -- To view, visit http://gerrit.cloudera.org:8080/19145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8499945fa57ea0499f65b455976141dcd6d789eb Gerrit-Change-Number: 19145 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Dec 2022 13:02:43 +0000 Gerrit-HasComments: Yes
