lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19109 )
Change subject: IMPALA-11390: Describe formatted statement on materialized view should show the view definition ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19109/5/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java: http://gerrit.cloudera.org:8080/#/c/19109/5/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@551 PS5, Line 551: // tableInfo.append(LINE_DELIM) : // .append("# Materialized View Source table information") : // .append(LINE_DELIM); : // TextMetaDataTable metaDataTable = new TextMetaDataTable(); : // metaDataTable.addRow("Table name", "I/U/D since last rebuild"); : // List<SourceTable> sourceTableList = : // new ArrayList<>(tbl.getCreationMetadata().getSourceTables()); : // sourceTableList.sort( : // Comparator : // .<SourceTable, String>comparing( : // sourceTable -> sourceTable.getTable().getDbName()) : // .thenComparing(sourceTable -> sourceTable.getTable().getTableName())); : // for (SourceTable sourceTable : sourceTableList) { : // String qualifiedTableName = TableName.getQualified( : // sourceTable.getTable().getCatName(), : // sourceTable.getTable().getDbName(), : // sourceTable.getTable().getTableName()); : // metaDataTable.addRow(qualifiedTableName, : // String.format("%d/%d/%d", : // sourceTable.getInsertedCount(), sourceTable.getUpdatedCount(), : // sourceTable.getDeletedCount())); : // tableInfo.append(metaDataTable.renderTable(isOutputPadded)); I'm confused about whether it's appropriate to comment so much code here. Take a look at others comments. -- To view, visit http://gerrit.cloudera.org:8080/19109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie62be1ca6d74370bad4b32bb046df93027e6f651 Gerrit-Change-Number: 19109 Gerrit-PatchSet: 5 Gerrit-Owner: pengdou <pengdou1...@126.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: pengdou <pengdou1...@126.com> Gerrit-Comment-Date: Thu, 08 Dec 2022 02:46:01 +0000 Gerrit-HasComments: Yes
