Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 )
Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement ...................................................................... Patch Set 6: (11 comments) Left a couple of comments, but the change looks great! http://gerrit.cloudera.org:8080/#/c/19145/6/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19145/6/be/src/service/client-request-state.cc@794 PS6, Line 794: { nit: could you please move the body of this statement to a separate function? http://gerrit.cloudera.org:8080/#/c/19145/6/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/19145/6/common/thrift/Frontend.thrift@376 PS6, Line 376: the new files has to be added to : // the Iceberg catalog. nit: "in this case we need to insert data to the Iceberg table based on the given files." http://gerrit.cloudera.org:8080/#/c/19145/6/common/thrift/Frontend.thrift@380 PS6, Line 380: whith nit: with http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java File fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@60 PS6, Line 60: ad nit: indendation is off http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@146 PS6, Line 146: IcebergTable Should be FeIcebergTable, so it works in local catalog mode as well. This could also be the reason thy the dockerised tests fail. http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@227 PS6, Line 227: !(table_ instanceof IcebergTable) nit: when partitionSpec_ != null then it is never an Iceberg table, right? http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@270 PS6, Line 270: LOAD formats nit: file format? Including 'filePathForLike' in the error message can be useful. http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@296 PS6, Line 296: IcebergTable FeIcebergTable http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/analysis/QueryStringBuilder.java File fe/src/main/java/org/apache/impala/analysis/QueryStringBuilder.java: http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/analysis/QueryStringBuilder.java@24 PS6, Line 24: The inner classes nit: The methods of the inner classes http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19145/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@257 PS6, Line 257: Path nit: please add some comments about the returned object http://gerrit.cloudera.org:8080/#/c/19145/6/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19145/6/tests/query_test/test_iceberg.py@795 PS6, Line 795: @SkipIf.not_hdfs Maybe this could be substituted to @SkipIfLocal.hdfs_client So the test would be executed on e.g. S3 -- To view, visit http://gerrit.cloudera.org:8080/19145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8499945fa57ea0499f65b455976141dcd6d789eb Gerrit-Change-Number: 19145 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Dec 2022 19:36:32 +0000 Gerrit-HasComments: Yes
