Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19353 )
Change subject: IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format ...................................................................... Patch Set 1: (1 comment) Clean followup of the previous commit, added one few nitpick, otherwise LGTM http://gerrit.cloudera.org:8080/#/c/19353/1/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/19353/1/be/src/exec/hdfs-scan-node-base.cc@306 PS1, Line 306: if (file_metadata) { We could add a DCHECK here too like L894, in case if we change/extend the file_metadata in the future and "file_metadata->iceberg_metadata()" can be nullptr -- To view, visit http://gerrit.cloudera.org:8080/19353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I941adfb659218283eb5fec1b394bb3003f8072a6 Gerrit-Change-Number: 19353 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Wed, 14 Dec 2022 09:49:45 +0000 Gerrit-HasComments: Yes
