Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19391 )
Change subject: IMPALA-11812: Deduplicate column schema in hmsPartitions ...................................................................... Patch Set 4: (7 comments) Thanks for your quick review, Aman! I'm still adding e2e tests for this patch. http://gerrit.cloudera.org:8080/#/c/19391/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19391/3//COMMIT_MSG@15 PS3, Line 15: interned, > nit: comma instead of period Done http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1842 PS3, Line 1842: numClusteringCols_, colsByPos_. > On line 1828 this value was stored as numClusteringCols_ so we could use t Done http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1842 PS3, Line 1842: numClusteringCols_, colsByPos_. > On line 1828 this value was stored as numClusteringCols_ so we could use t Done http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1877 PS3, Line 1877: laceSchemaF > nit: did you mean deduplicate instead of dereference ? Done http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java File fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java: http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@210 PS3, Line 210: > I am wondering why we would pass in a null cols list to begin with. Could Yeah, we can actually pass in the hmsTable instance from the callers. Made some refactors for this. http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@224 PS3, Line 224: */ > Since this method is actually force-setting the columns list for the partit Done. Renamed to 'replaceSchemaFromTable' and required hmsTable as the argument. I think the hmsTable instances all have non-null column list so we can simplify the code here. http://gerrit.cloudera.org:8080/#/c/19391/3/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@229 PS3, Line 229: etInputFormat(), > Could this also return null ? If so, given a set of partitions, we would h I'm not sure whether HMS will return a partition with this set to null. Refactored the code to use table schema instead. -- To view, visit http://gerrit.cloudera.org:8080/19391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I511ecca0ace8bea4c24a19a54fb0a75390e50c4d Gerrit-Change-Number: 19391 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 28 Dec 2022 11:05:23 +0000 Gerrit-HasComments: Yes
