Yida Wu has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19377 )
Change subject: IMPALA-11786: Preserve memory for codegen cache ...................................................................... IMPALA-11786: Preserve memory for codegen cache IMPALA-11470 adds support for codegen cache, however the admission controller is not aware of the memory usage of the codegen cache, while the codegen cache is actually using the memory quota from the query memory. It could result in query failures when running heavy workloads and admission controller has fully admitted queries. This patch subtracts the codegen cache capacity from the admission memory limit during initialization, therefore preserving the memory consumption of codegen cache from the beginning, and treating it as a separate memory independent to the query memory reservation. Also reduces the max codegen cache memory from 20 percent to 10 percent, and changes some failed testcases due to the reduction of the admit memory limit. Tests: Passed exhaustive tests. Change-Id: Iebdc04ba1b91578d74684209a11c815225b8505a --- M be/src/runtime/exec-env.cc M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_executor_groups.py M tests/custom_cluster/test_jvm_mem_tracking.py 4 files changed, 40 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/19377/4 -- To view, visit http://gerrit.cloudera.org:8080/19377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iebdc04ba1b91578d74684209a11c815225b8505a Gerrit-Change-Number: 19377 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
