Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19110 )
Change subject: WIP IMPALA-11629: Support for huawei OBS FileSystem ...................................................................... Patch Set 6: (2 comments) > Patch Set 6: > > Is the patch ready for review or still WIP? http://gerrit.cloudera.org:8080/#/c/19110/5/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/19110/5/be/src/runtime/io/disk-io-mgr.cc@148 PS5, Line 148: 16 > If this is not an empirical value, we can add a comment: 'TODO: choose the just follow other filesystem's corresponding value :) users can change it according to there own cluster's status. http://gerrit.cloudera.org:8080/#/c/19110/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19110/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@458 PS5, Line 458: e = > nit: if I think 'iff' is the meaning of 'if and only if', but a typo. -- To view, visit http://gerrit.cloudera.org:8080/19110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84a54dbebcc5b71e9bcdd141dae9e95104d98cb1 Gerrit-Change-Number: 19110 Gerrit-PatchSet: 6 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 02:32:03 +0000 Gerrit-HasComments: Yes
