Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 )
Change subject: IMPALA-11375 Impala shell outputs details of each RPC ...................................................................... Patch Set 11: Code-Review+1 (3 comments) LGTM http://gerrit.cloudera.org:8080/#/c/19388/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19388/11//COMMIT_MSG@2 PS11, Line 2: Author: jasonmfehr <jasonmf...@gmail.com> Nit: Author still shows gmail address http://gerrit.cloudera.org:8080/#/c/19388/9/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/19388/9/shell/impala_client.py@776 PS9, Line 776: key_value_pairs = set_query_options.items() > That's actually the formatting used elsewhere, thus I did not change it. ok http://gerrit.cloudera.org:8080/#/c/19388/11/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/19388/11/shell/option_parser.py@216 PS11, Line 216: "file. Ignored if protocol is beeswax.") Nit: delete double space -- To view, visit http://gerrit.cloudera.org:8080/19388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36f8dbc96726aa2a573133acbe8a558299381f8b Gerrit-Change-Number: 19388 Gerrit-PatchSet: 11 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 20:16:05 +0000 Gerrit-HasComments: Yes
