Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 )
Change subject: IMPALA-11808: Add support for reload event in catalogD ...................................................................... Patch Set 13: (7 comments) Some spelling nits http://gerrit.cloudera.org:8080/#/c/19378/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19378/13//COMMIT_MSG@14 PS13, Line 14: feature is disabled dy default using a config Nit: "by" http://gerrit.cloudera.org:8080/#/c/19378/13/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/19378/13/be/src/catalog/catalog-server.cc@128 PS13, Line 128: "to fire a refresh/invalidate table event to the HMS and other event processors " I don't understand this sentence. Should "and" be "so"? http://gerrit.cloudera.org:8080/#/c/19378/13/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/19378/13/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@429 PS13, Line 429: * CDP Hive-3 only function. Should we mention CDP in upstream code? http://gerrit.cloudera.org:8080/#/c/19378/13/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@439 PS13, Line 439: * CDP Hive-3 only function. Should we mention CDP in upstream code? http://gerrit.cloudera.org:8080/#/c/19378/13/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/19378/13/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@505 PS13, Line 505: * Fires an reload event to HMS notification log. In Hive-3 the relaod event Nit: "a reload", "the reload event" http://gerrit.cloudera.org:8080/#/c/19378/13/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/19378/13/tests/custom_cluster/test_events_custom_configs.py@246 PS13, Line 246: Some spaces here that could be deleted? http://gerrit.cloudera.org:8080/#/c/19378/13/tests/custom_cluster/test_events_custom_configs.py@252 PS13, Line 252: # Check if there is an reload event fired after refresh query. Nit: "a reload event" -- To view, visit http://gerrit.cloudera.org:8080/19378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62d58837d356dc2113f3c0904228ac9de484136 Gerrit-Change-Number: 19378 Gerrit-PatchSet: 13 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 21:42:37 +0000 Gerrit-HasComments: Yes
