Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 )
Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests ...................................................................... Patch Set 9: (44 comments) I have fixed all the indentation problems pointed out by impala-flake8 in patch set 9. http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@330 PS8, Line 330: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@332 PS8, Line 332: > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@333 PS8, Line 333: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@338 PS8, Line 338: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@341 PS8, Line 341: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@342 PS8, Line 342: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@347 PS8, Line 347: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@350 PS8, Line 350: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@351 PS8, Line 351: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@352 PS8, Line 352: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@357 PS8, Line 357: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@360 PS8, Line 360: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@384 PS8, Line 384: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@407 PS8, Line 407: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@410 PS8, Line 410: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@430 PS8, Line 430: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@437 PS8, Line 437: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@439 PS8, Line 439: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@440 PS8, Line 440: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@445 PS8, Line 445: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@451 PS8, Line 451: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@454 PS8, Line 454: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@460 PS8, Line 460: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@468 PS8, Line 468: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@470 PS8, Line 470: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@480 PS8, Line 480: > flake8: E241 multiple spaces after ',' Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@481 PS8, Line 481: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@484 PS8, Line 484: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@489 PS8, Line 489: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@510 PS8, Line 510: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@513 PS8, Line 513: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@518 PS8, Line 518: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@525 PS8, Line 525: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@527 PS8, Line 527: i > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@528 PS8, Line 528: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@534 PS8, Line 534: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@1205 PS8, Line 1205: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@1208 PS8, Line 1208: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@1210 PS8, Line 1210: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@1227 PS8, Line 1227: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@1230 PS8, Line 1230: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@1241 PS8, Line 1241: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@1244 PS8, Line 1244: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@1254 PS8, Line 1254: m > flake8: E131 continuation line unaligned for hanging indent Done -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 23:16:04 +0000 Gerrit-HasComments: Yes