Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19417 )

Change subject: IMPALA-11823: Add more items to Impala web UI queries page
......................................................................


Patch Set 1:

(15 comments)

http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/scheduling/admission-control-client.h
File be/src/scheduling/admission-control-client.h:

http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/scheduling/admission-control-client.h@48
PS1, Line 48:       std::unique_ptr<QuerySchedulePB>* schedule_result,
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/client-request-state.h
File be/src/service/client-request-state.h:

http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/client-request-state.h@355
PS1, Line 355:     int64_t wait_end_time_ms = wait_end_time_ms_ > 0LL ?
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/client-request-state.h@357
PS1, Line 357:     return wait_end_time_ms - wait_start_time_ms_;
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-http-handler.cc@440
PS1, Line 440:   const string& printed_queued_duration = 
PrettyPrinter::Print(record.wait_time_ms,
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-http-handler.cc@445
PS1, Line 445:   const string& printed_mem_usage = 
PrettyPrinter::Print(record.total_peak_mem_usage,
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-http-handler.cc@450
PS1, Line 450:   const string& printed_mem_est = 
PrettyPrinter::Print(record.cluster_mem_est,
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-http-handler.cc@471
PS1, Line 471:   const string& printed_bytes_read = 
PrettyPrinter::Print(record.bytes_read,
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.h
File be/src/service/impala-server.h:

http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.h@957
PS1, Line 957:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.h@1221
PS1, Line 1221:   typedef boost::unordered_map<TUniqueId, 
std::shared_ptr<QueryStateRecord>*>
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.h@1225
PS1, Line 1225:   /// Sets the given query_record (and retried_query_record too 
if given) for the given
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.h@1226
PS1, Line 1226:   /// query_id. Returns an error Status if the given query_id 
cannot be found in the
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.h@1229
PS1, Line 1229:       const TUniqueId& query_id, 
std::shared_ptr<QueryStateRecord>& query_record,
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.cc@754
PS1, Line 754:     // The record of the retried query should always be earlier 
in the query log compared
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.cc@755
PS1, Line 755:     // to the original query. Since the query log is a FIFO 
queue, this means that if the
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19417/1/be/src/service/impala-server.cc@961
PS1, Line 961:       is_query_missing =
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/19417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19c75461a6405025fa433ae84d2c94d013fcaacb
Gerrit-Change-Number: 19417
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <18770832...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 12:21:40 +0000
Gerrit-HasComments: Yes

Reply via email to