Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 )
Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19412/2/testdata/bin/rewrite-iceberg-metadata.py File testdata/bin/rewrite-iceberg-metadata.py: http://gerrit.cloudera.org:8080/#/c/19412/2/testdata/bin/rewrite-iceberg-metadata.py@69 PS2, Line 69: def fix_manifest_length(entry): > I think we should remove 'v' from the regex to also match metadata.json fil Done http://gerrit.cloudera.org:8080/#/c/19412/2/testdata/bin/rewrite-iceberg-metadata.py@83 PS2, Line 83: if 'format-version' not in metadata: > Could you please add support for absolute paths? Done -- To view, visit http://gerrit.cloudera.org:8080/19412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b9208f25552012cc1ab16fa60a819dd5a683d9 Gerrit-Change-Number: 19412 Gerrit-PatchSet: 4 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:30:22 +0000 Gerrit-HasComments: Yes
