Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 )
Change subject: WIP IMPALA-11745 ...................................................................... Patch Set 2: (18 comments) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/HiveEsriGeospatialBuiltins.java File fe/src/main/java/org/apache/impala/catalog/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/HiveEsriGeospatialBuiltins.java@160 PS2, Line 160: Generate ScalarFunctions for relational UDFs with a return type of boolean and two binary or string arguments line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/STUnionWrapper.java File fe/src/main/java/org/apache/impala/catalog/geospatial/STUnionWrapper.java: http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/STUnionWrapper.java@26 PS2, Line 26: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2);} line too long (143 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/STUnionWrapper.java@27 PS2, Line 27: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2, BytesWritable arg3) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2, arg3);} line too long (169 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/STUnionWrapper.java@28 PS2, Line 28: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2, BytesWritable arg3, BytesWritable arg4) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2, arg3, arg4);} line too long (195 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/STUnionWrapper.java@29 PS2, Line 29: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2, BytesWritable arg3, BytesWritable arg4, BytesWritable arg5) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2, arg3, arg4, arg5);} line too long (221 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/STUnionWrapper.java@30 PS2, Line 30: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2, BytesWritable arg3, BytesWritable arg4, BytesWritable arg5, BytesWritable arg6) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2, arg3, arg4, arg5, arg6);} line too long (247 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/StConvexHullWrapper.java File fe/src/main/java/org/apache/impala/catalog/geospatial/StConvexHullWrapper.java: http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/StConvexHullWrapper.java@25 PS2, Line 25: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2);} line too long (143 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/StConvexHullWrapper.java@26 PS2, Line 26: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2, BytesWritable arg3) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2, arg3);} line too long (169 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/StConvexHullWrapper.java@27 PS2, Line 27: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2, BytesWritable arg3, BytesWritable arg4) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2, arg3, arg4);} line too long (195 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/StConvexHullWrapper.java@28 PS2, Line 28: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2, BytesWritable arg3, BytesWritable arg4, BytesWritable arg5) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2, arg3, arg4, arg5);} line too long (221 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/catalog/geospatial/StConvexHullWrapper.java@29 PS2, Line 29: public BytesWritable evaluate(BytesWritable arg1, BytesWritable arg2, BytesWritable arg3, BytesWritable arg4, BytesWritable arg5, BytesWritable arg6) throws UDFArgumentLengthException { return super.evaluate(arg1, arg2, arg3, arg4, arg5, arg6);} line too long (247 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@93 PS2, Line 93: public List<ScalarFunction> extract(HiveLegacyFunctionExtractor extractor) throws CatalogException { line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java@46 PS2, Line 46: public List<ScalarFunction> extract(HiveLegacyFunctionExtractor extractor)throws CatalogException; line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java: http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java@73 PS2, Line 73: protected List<Type> resolveArgumentTypes(List<Class<?>> arguments) throws ImpalaException{ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@140 PS2, Line 140: public List<ScalarFunction> extract(HiveLegacyFunctionExtractor extractor) throws CatalogException { line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java File fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java: http://gerrit.cloudera.org:8080/#/c/19425/2/fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java@37 PS2, Line 37: public List<ScalarFunction> extract(HiveLegacyFunctionExtractor extractor) throws CatalogException { line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/19425/2/tests/custom_cluster/test_geospatial_udfs.py File tests/custom_cluster/test_geospatial_udfs.py: http://gerrit.cloudera.org:8080/#/c/19425/2/tests/custom_cluster/test_geospatial_udfs.py@23 PS2, Line 23: class TestGeospatialUdfs(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19425/2/tests/custom_cluster/test_geospatial_udfs.py@45 PS2, Line 45: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/19425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0ca02a70b4ba244778c9db6d14df4423072b225 Gerrit-Change-Number: 19425 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Jan 2023 14:26:04 +0000 Gerrit-HasComments: Yes
