Quanlong Huang has uploaded this change for review. (
http://gerrit.cloudera.org:8080/19429
Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in
resolvePathWithMasking
......................................................................
IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking
resolvePathWithMasking() is a wrapper on resolvePath() to further
resolve nested columns inside the table masking view. While it was
added, complex types in the select list haven't been supported yet. So
the table masking view can't expose complex type columns directly in the
select list. Any paths in nested types will be further resolved inside
the table masking view in resolvePathWithMasking().
Take the following query as an example:
select id, nested_struct.* from complextypestbl;
If Ranger column-masking/row-filter policies applied on the table, the
query is rewritten as
select id, nested_struct.* from (
select mask(id) from complextypestbl
where row-filtering-condition
) t;
Table masking view "t" can't expose the nested column "nested_struct".
So we further resolve it inside the inlineView if it's a table masking
view.
Paths that don't reference nested columns are resolved and returned
directly (just like the original resolvePath() does). However, the
current check on STAR type paths doesn't really recognize the nested
columns:
- The type is STRUCT
- The resolved path is root at a valid tuple descriptor
STAR expansion is only valid for paths to a struct type (or a
table/view). So the first condition always matches. The second condition
also matches for STAR paths on table/view, i.e. paths of "v.*" when "v"
is a catalog table/view. The code then treats all paths of "v.*" as
nested column expansion so result in IllegalStateException.
This patch fixes the check for nested struct STAR expansion by checking
the matched types instead. Note that if "v.*" is a table/view expansion,
the matched type list is empty. If "v.*" is a struct column expansion,
the matched type list contains the STRUCT column type.
Tests:
- Add missing coverage on STAR paths (v.*) on masked views.
Change-Id: I8f1e78e325baafbe23101909d47e82bf140a2d77
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/Path.java
M
testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test
M
testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
4 files changed, 66 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/19429/1
--
To view, visit http://gerrit.cloudera.org:8080/19429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f1e78e325baafbe23101909d47e82bf140a2d77
Gerrit-Change-Number: 19429
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
