Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19430 )
Change subject: IMPALA-3120: Support Bucket Shuffle Join for bucketed table ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/19430/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/19430/1/be/src/runtime/coordinator-backend-state.cc@149 PS1, Line 149: *fragment_ctx->mutable_bucket_backend_map() = exec_params_.query_schedule().bucket_backend_map(); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/19430/1/be/src/runtime/data-stream-test.cc File be/src/runtime/data-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/19430/1/be/src/runtime/data-stream-test.cc@624 PS1, Line 624: data_sink->tsink_->stream_sink, dest_, channel_buffer_size, &state, bucket_backend_map)); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/19430/1/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/19430/1/be/src/scheduling/scheduler.cc@433 PS1, Line 433: const BackendDescriptorPB& backend_descriptor = LookUpBackendDesc(executor_config, host); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/19430/1/be/src/scheduling/scheduler.cc@1046 PS1, Line 1046: scan_range_params.scan_range().bucket_id() % fragment_state->fragment.bucket_info.num_bucket) line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/19430/1/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/19430/1/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@624 PS1, Line 624: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19430/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/19430/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2542 PS1, Line 2542: * 判定所有选取的partition 是否按照相同的规则进行kudu hash分桶（文件命名规则是否相同， 桶总数是否相同） line too long (145 > 90) http://gerrit.cloudera.org:8080/#/c/19430/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/19430/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1207 PS1, Line 1207: if (1.0 * childBucketInfo.getNum_bucket() / numExecutors >= bucketExecBucketBackendRatio) { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/19430/1/tests/query_test/test_bucket_shuffle.py File tests/query_test/test_bucket_shuffle.py: http://gerrit.cloudera.org:8080/#/c/19430/1/tests/query_test/test_bucket_shuffle.py@40 PS1, Line 40: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/19430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If321e7987bc88374d79500cffb77ea25b2ed0316 Gerrit-Change-Number: 19430 Gerrit-PatchSet: 1 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Jan 2023 11:31:53 +0000 Gerrit-HasComments: Yes
