Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 )
Change subject: IMPALA-11604 Planner changes for CPU usage ...................................................................... Patch Set 32: (2 comments) http://gerrit.cloudera.org:8080/#/c/19033/32//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19033/32//COMMIT_MSG@169 PS32, Line 169: Compute the total ProcessingCost of the query > We calculate total ProcessingCost of the query and CoreRequirement in IV. W ProcessingCost is used to derive CoreRequirement in section IV. My intention is to only use CoreRequirement for finding suitable executor group. I will clarify this in commit message. http://gerrit.cloudera.org:8080/#/c/19033/32/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/19033/32/common/thrift/Frontend.thrift@779 PS32, Line 779: total CPU cores among all executor > The max_mem_limit is defined as per host estimated-memory limit. We may def Ack. I will cross check with your IMPALA-11617 patch as well. -- To view, visit http://gerrit.cloudera.org:8080/19033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32dc770dfffcdd0be2b5555a789a7720952c68a Gerrit-Change-Number: 19033 Gerrit-PatchSet: 32 Gerrit-Owner: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Jan 2023 21:53:03 +0000 Gerrit-HasComments: Yes
