Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19401 )
Change subject: IMPALA-3880: Add list of all tables queried to runtime profile ...................................................................... Patch Set 2: (2 comments) > Patch Set 1: Code-Review+1 > > (2 comments) > > LGTM, added a few nitpicks, feel free to carry over my +1 http://gerrit.cloudera.org:8080/#/c/19401/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19401/1//COMMIT_MSG@12 PS1, Line 12: > Could you add a short note about the testing you've added Done http://gerrit.cloudera.org:8080/#/c/19401/1/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/19401/1/tests/shell/test_shell_commandline.py@394 PS1, Line 394: statements = ['select id from %s.shell_profile_test' % db, > Maybe we could add a query referencing multiple tables, e.g. a join. Done -- To view, visit http://gerrit.cloudera.org:8080/19401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib474a5c6522032679701103aa225a18edca62f5a Gerrit-Change-Number: 19401 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Jan 2023 15:45:27 +0000 Gerrit-HasComments: Yes
