Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 )
Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking ...................................................................... Patch Set 5: (2 comments) Thanks for preparing a fix so quickly Quanlong! I only have 2 very minor comments and the second one regarding adding a code comment is only optional. I raised that question because I do not know enough about how paths are resolved in Impala's FE in detail. http://gerrit.cloudera.org:8080/#/c/19429/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19429/5//COMMIT_MSG@39 PS5, Line 39: as a nit: "as a" should be put in the next line. http://gerrit.cloudera.org:8080/#/c/19429/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19429/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1196 PS5, Line 1196: resolvedPath.getMatchedTypes( Is it true that when 'pathType' is PathType.STAR and resolvedPath.getMatchedTypes() is not empty, 'resolvedPath' has to correspond to a struct column, e.g., the column of 'nested_struct' of the table 'complextypestbl' under the database 'functional_parquet'? If so, it may be good to add a more detailed code comment at the definition of 'matchedTypes_' in Path.java as well. -- To view, visit http://gerrit.cloudera.org:8080/19429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f1e78e325baafbe23101909d47e82bf140a2d77 Gerrit-Change-Number: 19429 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 23 Jan 2023 05:05:30 +0000 Gerrit-HasComments: Yes
