Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19214 )
Change subject: IMPALA-7969: Always admit trivial queries immediately ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/19214/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19214/5//COMMIT_MSG@33 PS5, Line 33: runni > using -> running Done http://gerrit.cloudera.org:8080/#/c/19214/5//COMMIT_MSG@42 PS5, Line 42: could be extended in fu > 'might be able to extend in future' => Done http://gerrit.cloudera.org:8080/#/c/19214/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19214/6//COMMIT_MSG@31 PS6, Line 31: If the maximum parallelism is reached, : the admission controller would try to admit the trivial query : via normal process. > Would be good to add a test case for this scenario, if we don't have one al test_trivial_query_multi_runs in the ee test should cover the case, and the testcase ensures successful runs when max parallelism is reached. Added test_trivial_query_multi_runs_fallback to create an error case that fallback and blocked by a long query then timeout. http://gerrit.cloudera.org:8080/#/c/19214/5/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/19214/5/be/src/scheduling/admission-controller.h@666 PS5, Line 666: in > on -> in Done http://gerrit.cloudera.org:8080/#/c/19214/5/be/src/scheduling/admission-controller.h@979 PS5, Line 979: the quer > 'schedule' => 'query' Done -- To view, visit http://gerrit.cloudera.org:8080/19214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a729764e3055d7eb11900c96c82ff53eb261f91 Gerrit-Change-Number: 19214 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 24 Jan 2023 00:44:22 +0000 Gerrit-HasComments: Yes
