Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 )
Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins ...................................................................... Patch Set 14: (10 comments) http://gerrit.cloudera.org:8080/#/c/19425/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19425/13//COMMIT_MSG@34 PS13, Line 34: n > That's the minimum setting where the tests still passing. It can be changed I see. We can leave it that way or choose a common number, either is fine for me. http://gerrit.cloudera.org:8080/#/c/19425/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19425/14//COMMIT_MSG@19 PS14, Line 19: and partial generics support Optional: we could say "and only partial ..." http://gerrit.cloudera.org:8080/#/c/19425/14/common/function-registry/gen_geospatial_udf_wrappers.py File common/function-registry/gen_geospatial_udf_wrappers.py: http://gerrit.cloudera.org:8080/#/c/19425/14/common/function-registry/gen_geospatial_udf_wrappers.py@20 PS14, Line 20: Thanks for the descriprion. Now it is formatted to have 60 character lines but we allow 90. http://gerrit.cloudera.org:8080/#/c/19425/14/common/function-registry/gen_geospatial_udf_wrappers.py@55 PS14, Line 55: METHOD_FORMAT = """ public {return_type} evaluate({parameter_list}) {exception_clause}{{ These constants would be more logically placed in the Wrapper class. http://gerrit.cloudera.org:8080/#/c/19425/14/common/function-registry/gen_geospatial_udf_wrappers.py@58 PS14, Line 58: """ Because of the newline at the end of METHOD_FORMAT there's an empty line in the class after the last method. We could remove this newline here and use "\n\n" as the joining string instead. http://gerrit.cloudera.org:8080/#/c/19425/14/common/function-registry/gen_geospatial_udf_wrappers.py@78 PS14, Line 78: "" Why isn't it False? http://gerrit.cloudera.org:8080/#/c/19425/14/common/function-registry/gen_geospatial_udf_wrappers.py@79 PS14, Line 79: base_class We could call it self.original_class. http://gerrit.cloudera.org:8080/#/c/19425/14/common/function-registry/gen_geospatial_udf_wrappers.py@98 PS14, Line 98: , Should be ", ". http://gerrit.cloudera.org:8080/#/c/19425/14/common/function-registry/gen_geospatial_udf_wrappers.py@104 PS14, Line 104: , Should be ", ". http://gerrit.cloudera.org:8080/#/c/19425/13/fe/src/main/java/org/apache/impala/catalog/HiveEsriGeospatialBuiltins.java File fe/src/main/java/org/apache/impala/catalog/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/19425/13/fe/src/main/java/org/apache/impala/catalog/HiveEsriGeospatialBuiltins.java@261 PS13, Line 261: > Replaced with the original call What does this method print? -- To view, visit http://gerrit.cloudera.org:8080/19425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0ca02a70b4ba244778c9db6d14df4423072b225 Gerrit-Change-Number: 19425 Gerrit-PatchSet: 14 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Jan 2023 13:12:11 +0000 Gerrit-HasComments: Yes
