Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 )
Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit ...................................................................... Patch Set 4: (1 comment) Just questions, I'm not requesting changes http://gerrit.cloudera.org:8080/#/c/19366/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19366/4//COMMIT_MSG@14 PS4, Line 14: available per node and coordinator for each executor group, to the pool Is it right that typically the CPU core limit should be set to the number of cores for the CPU? If so we should say that explicitly to help users. It's a pity that this can't be done automatically in some way, though I can see that would be hard. What would be the consequences of setting the wrong value, both too high or too low? Could we provide warnings if the value is badly wrong? Again I think that may be hard. -- To view, visit http://gerrit.cloudera.org:8080/19366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4c5ee519ce7c329b06ac821283e215a3560f525 Gerrit-Change-Number: 19366 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Jan 2023 01:51:15 +0000 Gerrit-HasComments: Yes
