Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19472 )
Change subject: IMPALA-10804: [DOCS] Document spill to remote storage ...................................................................... Patch Set 1: Code-Review+1 (2 comments) It looks good. Just minor things. http://gerrit.cloudera.org:8080/#/c/19472/1/docs/topics/impala_disk_space.xml File docs/topics/impala_disk_space.xml: http://gerrit.cloudera.org:8080/#/c/19472/1/docs/topics/impala_disk_space.xml@422 PS1, Line 422: maximum is 256MB I think the maximum is updated to 512MB in the code, https://github.com/apache/impala/blob/40da36414ff4d46b5cdc53f068b1f0a5b28a0f1d/be/src/runtime/tmp-file-mgr.cc#L142. But the comment has not been updated in https://github.com/apache/impala/blob/40da36414ff4d46b5cdc53f068b1f0a5b28a0f1d/be/src/runtime/tmp-file-mgr.cc#L101. Will file another jira for changing the comment. http://gerrit.cloudera.org:8080/#/c/19472/1/docs/topics/impala_disk_space.xml@450 PS1, Line 450: ip_address nit. seems we have different spellings for the ip address, ipaddr or ip_address, could you please change to use only one, either would be good. -- To view, visit http://gerrit.cloudera.org:8080/19472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3efb2ffcc06cdbe69845c6dc4cf03d9f2e3dcabc Gerrit-Change-Number: 19472 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 23:43:35 +0000 Gerrit-HasComments: Yes
