Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 )
Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins ...................................................................... Patch Set 26: (2 comments) http://gerrit.cloudera.org:8080/#/c/19425/25/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/19425/25/tests/common/skip.py@255 PS25, Line 255: Nit: -2 indentation, and the next line is a continuation line, so it should be indented +4 relative to this line. http://gerrit.cloudera.org:8080/#/c/19425/25/tests/custom_cluster/test_geospatial_library.py File tests/custom_cluster/test_geospatial_library.py: http://gerrit.cloudera.org:8080/#/c/19425/25/tests/custom_cluster/test_geospatial_library.py@34 PS25, Line 34: @SkipIfApacheHive.feature_not_supported Do we have to skip this test? If we're using Apache Hive, can't / shouldn't we verify that the functions are not present? -- To view, visit http://gerrit.cloudera.org:8080/19425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0ca02a70b4ba244778c9db6d14df4423072b225 Gerrit-Change-Number: 19425 Gerrit-PatchSet: 26 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:57:03 +0000 Gerrit-HasComments: Yes
