Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19481 )
Change subject: IMPALA-11834: Error reporting addendum ...................................................................... Patch Set 2: (1 comment) Thanks, just a small comment. http://gerrit.cloudera.org:8080/#/c/19481/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19481/2/be/src/service/client-request-state.cc@885 PS2, Line 885: errno Before this change we added "query_status.msg().msg()" to the status error message. Was it only relevant for the "!hdfs_ret.ok()" case? See also L908. -- To view, visit http://gerrit.cloudera.org:8080/19481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iece31fa19b7448095462671acb2f02e8c5a405ae Gerrit-Change-Number: 19481 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 12:14:48 +0000 Gerrit-HasComments: Yes
