Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 )
Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/19428/10/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/19428/10/shell/impala_client.py@434 PS10, Line 434: transport.addCustomHeaderFunc(self.get_custom_http_headers) > I think you need to test whether this function exists, or also add it non-H As far as I can tell, the Beeswax client initialization does not run this code. At this point, the "transport" variable should only even by of type ImpalaHttpClient which defines "addCustomHeaderFunc": https://github.com/jasonmfehr/impala/blob/28694d4ec07616b6dbaaaea8f4feaf40454da2f5/shell/ImpalaHttpClient.py#L239 -- To view, visit http://gerrit.cloudera.org:8080/19428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7857eb5ec03eba32e06ec8d4133480f2e958ad2f Gerrit-Change-Number: 19428 Gerrit-PatchSet: 10 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 23:29:00 +0000 Gerrit-HasComments: Yes
