Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18705 )
Change subject: IMPALA-11417: Support outer join elimination optimization ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/18705/10/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/18705/10/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2071 PS10, Line 2071: && canEliminateInnerPlan(analyzer, inner, innerRef, eqJoinConjuncts, otherJoinConjuncts)) { line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/18705/10/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/18705/10/tests/query_test/test_join_queries.py@89 PS10, Line 89: d flake8: F811 redefinition of unused 'test_outer_joins' from line 83 http://gerrit.cloudera.org:8080/#/c/18705/10/tests/query_test/test_join_queries.py@121 PS10, Line 121: class TestJoinElimination(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18705/10/tests/query_test/test_join_queries.py@131 PS10, Line 131: \ flake8: E502 the backslash is redundant between brackets -- To view, visit http://gerrit.cloudera.org:8080/18705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2e68263a029ac84a4f35b0846b22aa42d7ceece Gerrit-Change-Number: 18705 Gerrit-PatchSet: 10 Gerrit-Owner: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Comment-Date: Wed, 08 Feb 2023 10:08:50 +0000 Gerrit-HasComments: Yes
