Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19471 )
Change subject: IMPALA-11081: Fix incorrect results in partition key scan ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/19471/10/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/19471/10/tests/query_test/test_queries.py@347 PS10, Line 347: src_tbl_name = 'functional' + db_suffix + '.alltypes' : src_tbl_loc = self._get_table_location(src_tbl_name, vector) : source_file = src_tbl_loc + '/year=2010/month=12/*' : tbl_loc = get_fs_path("/test-warehouse/%s.db/alltypes_multiblocks" : % (unique_database)) > I'm not clear why adding '_def' in the suffix. If you want the db_suffix of Done http://gerrit.cloudera.org:8080/#/c/19471/10/tests/query_test/test_queries.py@353 PS10, Line 353: : check_call(['hdfs', 'dfs', '-mkdir', '-p', file_path > I also see this in tests/metadata/test_partition_metadata.py. I think it's Done http://gerrit.cloudera.org:8080/#/c/19471/10/tests/query_test/test_queries.py@358 PS10, Line 358: : # set block size to 1024 so the target file occupies multiple blocks : check_call(['hdfs', 'dfs', '-Ddfs.block.size=1024', '-cp', '-f', '-d', : source_file, file_path]) : self.client.execute("alter table %s.alltypes_multiblocks recover partitions" : % (unique_database)) : > I think we can get the source table location by the _get_table_location() u Done -- To view, visit http://gerrit.cloudera.org:8080/19471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17331ed6c26a747e0509dcbaf427cd52808943b1 Gerrit-Change-Number: 19471 Gerrit-PatchSet: 11 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Wed, 08 Feb 2023 11:46:11 +0000 Gerrit-HasComments: Yes
