Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18977 )

Change subject: IMPALA-10408: Support build using Apache components
......................................................................


Patch Set 5:

(3 comments)

> Patch Set 4:
>
> I think build failure is not related to changed codes.
> It caused by server certification verficiation error.
>
> "fatal: unable to access 'https://gerrit.cloudera.org/Impala-ASF/': server 
> certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt 
> CRLfile: none"

After the certificate issue is resolved, I retriggered the job: 
https://jenkins.impala.io/job/gerrit-code-review-checks/12355/

There is a build failure on FE:

00:14:45 [ERROR] [ERROR] Some problems were encountered while processing the 
POMs:
[ERROR] 'dependencies.dependency.version' for commons-lang:commons-lang:jar 
must be a valid version but is '${commons-io.version}'. @ 
org.apache.impala:impala-frontend:[unknown-version], 
/home/ubuntu/Impala/fe/pom.xml, line 284, column 16
[ERROR] 'dependencies.dependency.version' for commons-lang:commons-lang:jar 
must be a valid version but is '${commons-io.version}'. @ 
org.apache.impala:nested-table-flattener:[unknown-version], 
/home/ubuntu/Impala/java/TableFlattener/pom.xml, line 70, column 16
00:14:45 [ERROR] The build could not read 2 projects -> [Help 1]
00:14:45 [ERROR]
00:14:45 [ERROR]   The project org.apache.impala:impala-frontend:4.3.0-SNAPSHOT 
(/home/ubuntu/Impala/fe/pom.xml) has 1 error
00:14:45 [ERROR]     'dependencies.dependency.version' for 
commons-lang:commons-lang:jar must be a valid version but is 
'${commons-io.version}'. @ org.apache.impala:impala-frontend:[unknown-version], 
/home/ubuntu/Impala/fe/pom.xml, line 284, column 16
00:14:45 [ERROR]
00:14:45 [ERROR]   The project 
org.apache.impala:nested-table-flattener:4.3.0-SNAPSHOT 
(/home/ubuntu/Impala/java/TableFlattener/pom.xml) has 1 error
00:14:45 [ERROR]     'dependencies.dependency.version' for 
commons-lang:commons-lang:jar must be a valid version but is 
'${commons-io.version}'. @ 
org.apache.impala:nested-table-flattener:[unknown-version], 
/home/ubuntu/Impala/java/TableFlattener/pom.xml, line 70, column 16
00:14:45 [ERROR]
00:14:45 [ERROR] To see the full stack trace of the errors, re-run Maven with 
the -e switch.
00:14:45 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
00:14:45 [ERROR]
00:14:45 [ERROR] For more information about the errors and possible solutions, 
please read the following articles:
00:14:45 [ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
mvn -U -U -B install -DskipTests exited with code 0

More in https://jenkins.impala.io/job/ubuntu-16.04-build-only/17602/console

http://gerrit.cloudera.org:8080/#/c/18977/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18977/5//COMMIT_MSG@8
PS5, Line 8:
Please mention how this is supported and how you verified the build. Did all 
the tests pass?

Please also mention why we need changes on RangerAccessRequestImpl in the 
commit message.


http://gerrit.cloudera.org:8080/#/c/18977/5/bin/jenkins/build-all-flag-combinations.sh
File bin/jenkins/build-all-flag-combinations.sh:

http://gerrit.cloudera.org:8080/#/c/18977/5/bin/jenkins/build-all-flag-combinations.sh@48
PS5, Line 48:   "-skiptests -noclean -use_apache_hive"
We need new options here for the apache build so we can verify it in the 
pre-commit jobs.


http://gerrit.cloudera.org:8080/#/c/18977/5/java/TableFlattener/pom.xml
File java/TableFlattener/pom.xml:

http://gerrit.cloudera.org:8080/#/c/18977/5/java/TableFlattener/pom.xml@70
PS5, Line 70: commons-io.version
This need to be defined in java/pom.xml.

Could you also mention the reason of adding commons-lang in the commit message?



--
To view, visit http://gerrit.cloudera.org:8080/18977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399
Gerrit-Change-Number: 18977
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <eubn...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eubn...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Comment-Date: Wed, 15 Feb 2023 00:40:11 +0000
Gerrit-HasComments: Yes

Reply via email to