David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/19506 )
Change subject: IMPALA-11924: Cap runtime filter NDV with build key NDV ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19506/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/19506/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@713 PS1, Line 713: filterSizeBytes_ = Math.max(filterSizeBytes_, filterSizeLimits.minVal); It would be useful to log under trace the filters where we've reduced or increased the size based on the configured size limits (along with their original unbounded filterSizeBytes_ value). http://gerrit.cloudera.org:8080/#/c/19506/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@774 PS1, Line 774: if (numBloomFilters >= maxNumBloomFilters) continue; Not directly related to the NDV change but it would be useful to log under trace the filters that we're skipping here because we've exceeded the configured max count. -- To view, visit http://gerrit.cloudera.org:8080/19506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa46789663cb2e6d29f518757d89c85ff8e4d1a Gerrit-Change-Number: 19506 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 16 Feb 2023 20:28:37 +0000 Gerrit-HasComments: Yes
