Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19507 )
Change subject: IMPALA-11854: ImpalaStringWritable's underlying array can't be changed in UDFs ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/19507/4/fe/src/main/java/org/apache/impala/hive/executor/ImpalaStringWritable.java File fe/src/main/java/org/apache/impala/hive/executor/ImpalaStringWritable.java: http://gerrit.cloudera.org:8080/#/c/19507/4/fe/src/main/java/org/apache/impala/hive/executor/ImpalaStringWritable.java@104 PS4, Line 104: > By default, Object's equals method will do exactly the same as the == opera Ok, for some reason I thought that arrays overrode 'equals()' to do what Lists do. http://gerrit.cloudera.org:8080/#/c/19507/7/java/test-hive-udfs/src/main/java/org/apache/impala/CachedWritablesUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/CachedWritablesUdf.java: http://gerrit.cloudera.org:8080/#/c/19507/7/java/test-hive-udfs/src/main/java/org/apache/impala/CachedWritablesUdf.java@29 PS7, Line 29: now every data manipulation : * operation on array-backed writables loads the corresponding data It is a bit unclear to me, could you make it clearer that we load it once and subsequent manipulations use the already loaded (and possibly changed) value? http://gerrit.cloudera.org:8080/#/c/19507/7/java/test-hive-udfs/src/main/java/org/apache/impala/GenericCachedWritablesUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/GenericCachedWritablesUdf.java: http://gerrit.cloudera.org:8080/#/c/19507/7/java/test-hive-udfs/src/main/java/org/apache/impala/GenericCachedWritablesUdf.java@75 PS7, Line 75: bytes 'bytes' could be declared and assigned here, no need to forward declare it. See alson L80. -- To view, visit http://gerrit.cloudera.org:8080/19507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb28bd0dce7b0482c7abe1f61f245691fcbfe212 Gerrit-Change-Number: 19507 Gerrit-PatchSet: 7 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Wed, 22 Feb 2023 13:48:05 +0000 Gerrit-HasComments: Yes
