Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19535 )
Change subject: IMPALA-11943: Mark utf8 string functions with IR_ALWAYS_INLINE ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/mask-functions-ir.cc@778 PS1, Line 778: IR_ALWAYS_INLINE StringVal MaskFunctions::Mask(FunctionContext* ctx, const StringVal& val) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/string-functions-ir.cc@256 PS1, Line 256: IR_ALWAYS_INLINE IntVal StringFunctions::Length(FunctionContext* context, const StringVal& str) { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/string-functions-ir.cc@289 PS1, Line 289: IR_ALWAYS_INLINE StringVal StringFunctions::Lower(FunctionContext* context, const StringVal& str) { line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/string-functions-ir.cc@307 PS1, Line 307: IR_ALWAYS_INLINE StringVal StringFunctions::Upper(FunctionContext* context, const StringVal& str) { line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/string-functions-ir.cc@329 PS1, Line 329: IR_ALWAYS_INLINE StringVal StringFunctions::InitCap(FunctionContext* context, const StringVal& str) { line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/string-functions-ir.cc@621 PS1, Line 621: IR_ALWAYS_INLINE StringVal StringFunctions::Reverse(FunctionContext* context, const StringVal& str) { line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/19535/1/be/src/exprs/string-functions-ir.cc@790 PS1, Line 790: IR_ALWAYS_INLINE IntVal StringFunctions::Instr(FunctionContext* context, const StringVal& str, line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/19535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e8fba332ae329da8b1d37dba3bbc64f59e6f3a Gerrit-Change-Number: 19535 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Feb 2023 14:08:10 +0000 Gerrit-HasComments: Yes
