Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19530 )
Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg ...................................................................... Patch Set 4: (2 comments) Thanks for adding docs for it! http://gerrit.cloudera.org:8080/#/c/19530/4/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/19530/4/docs/topics/impala_iceberg.xml@617 PS4, Line 617: for Impala Maybe we should mention that it is useful for the Coordinators and CatalogD as well. http://gerrit.cloudera.org:8080/#/c/19530/4/docs/topics/impala_iceberg.xml@623 PS4, Line 623: 60000 nit: people might just blindly copying the values from here. So we probably want to provide a higher value as an example than one minute, e.g. one hour? -- To view, visit http://gerrit.cloudera.org:8080/19530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd761a81f5c81a25a5ec0889402f85157c23e9fe Gerrit-Change-Number: 19530 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Feb 2023 16:38:32 +0000 Gerrit-HasComments: Yes
