Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19533 )
Change subject: IMPALA-11858: Cap per backend memory estimate to its memory limit for admission ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19533/2/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/19533/2/be/src/scheduling/admission-controller-test.cc@877 PS2, Line 877: set_is_executor(false); If the node is set as executor and coordinator, the assumption mat not work. http://gerrit.cloudera.org:8080/#/c/19533/2/be/src/scheduling/schedule-state.h File be/src/scheduling/schedule-state.h: http://gerrit.cloudera.org:8080/#/c/19533/2/be/src/scheduling/schedule-state.h@288 PS2, Line 288: The assumption is that all : /// executors have the same memory limit for admission and all the coordinators have the : /// same memory limit for admission. Is the assumption working if one node is set as both executor and coordinator? -- To view, visit http://gerrit.cloudera.org:8080/19533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b1f6e530785ef832dbc831d7cc6793133f3335c Gerrit-Change-Number: 19533 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Feb 2023 19:16:44 +0000 Gerrit-HasComments: Yes
