Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19155 )
Change subject: IMPALA-11626: Handle COMMIT_COMPACTION_EVENT from HMS ...................................................................... Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/19155/10/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/19155/10/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2653 PS10, Line 2653: private org.apache.impala.catalog.Table tbl_; > unused variable Ack http://gerrit.cloudera.org:8080/#/c/19155/10/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2695 PS10, Line 2695: } > I think we should reuse the implementation in MetastoreTableEvent instead o Ack http://gerrit.cloudera.org:8080/#/c/19155/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19155/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4521 PS10, Line 4521: or reload > nit: move this to the above line Ack http://gerrit.cloudera.org:8080/#/c/19155/9/fe/src/test/resources/hive-site.xml.py File fe/src/test/resources/hive-site.xml.py: http://gerrit.cloudera.org:8080/#/c/19155/9/fe/src/test/resources/hive-site.xml.py@167 PS9, Line 167: # Since HIVE-22589, Hive uses Julian Calendar for writing dates before 1582-10-15, > Thanks for the explanation! Could you comment this in the new test? Ack http://gerrit.cloudera.org:8080/#/c/19155/10/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/19155/10/tests/custom_cluster/test_events_custom_configs.py@268 PS10, Line 268: 5 > Could you comment why we need such a long inverval (5s)? I think the reason Ack http://gerrit.cloudera.org:8080/#/c/19155/10/tests/custom_cluster/test_events_custom_configs.py@284 PS10, Line 284: .format(unique_database, test_cc_part_table)) : for i in range(11): : self.run_stmt_in_hive( > Can we remove commented codes? Ack http://gerrit.cloudera.org:8080/#/c/19155/10/tests/custom_cluster/test_events_custom_configs.py@287 PS10, Line 287: "insert into {}.{} partition (year=2022) values (1),(2),(3)" > Should we call EventProcessorUtils.wait_for_event_processing(self) before t The current test time is about 250~350 secs. With/without your suggestion, the test is passing anyway. So I'm kind of hesitant to include your suggestion and increase the test running time. -- To view, visit http://gerrit.cloudera.org:8080/19155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I464faedb4e3bbcd417bab2e3cb0d57e339d42605 Gerrit-Change-Number: 19155 Gerrit-PatchSet: 11 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Feb 2023 19:20:58 +0000 Gerrit-HasComments: Yes
